refactor: Make 'vite-prerender-plugin' optional#184
Draft
rschristian wants to merge 3 commits intov3from
Draft
Conversation
Draft
rschristian
commented
Mar 10, 2026
Comment on lines
-66
to
-74
| if (!prerender.previewMiddlewareEnabled) { | ||
| const idx = prerenderPlugin.findIndex( | ||
| p => p.name == "serve-prerendered-html", | ||
| ); | ||
| if (idx > -1) { | ||
| prerenderPlugin.splice(idx, 1); | ||
| } | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Vite's preview server routes everything back to index.html, which is a problem when testing prerendered apps as few people are actually using paths like /foo.html to navigate.
I added a plugin years ago to help with this but cautiously made it opt-in here to avoid any potential for breaking changes. We can remove this now, IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today, it brings in 18 deps (some of which may be deduped, not sure) and it's not necessarily something everyone wants or needs; better to lighten the load and make it an optional peer dep instead. Users can configure & access it through the Preact plugin but will be able to control the version themselves a bit more freely.
Alternatively, we can strip it out altogether if people prefer; I don't have too much of an opinion.