Allow Customizing Diff Logic (via new shouldUpdate method)#218
Open
sghoweri wants to merge 3 commits intopreactjs:mainfrom
Open
Allow Customizing Diff Logic (via new shouldUpdate method)#218sghoweri wants to merge 3 commits intopreactjs:mainfrom
shouldUpdate method)#218sghoweri wants to merge 3 commits intopreactjs:mainfrom
Conversation
…e default compare logic to customizable
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Changing prototype is affecting all signals. I thinks it's not a best way to provide custom equality checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a way to (optionally) customize how incoming values are evaluated (ie. has this value actually changed) via the new
shouldUpdatemethod; a very similar use case to #103 that I also ran into!Also adds a new test to demonstrate before vs after behavior + a tiny usage example.