Fix React.lazy and React.forwardRef component updates tracking. - #427
Fix React.lazy and React.forwardRef component updates tracking.#427XantreDev wants to merge 6 commits into
React.lazy and React.forwardRef component updates tracking.#427Conversation
🦋 Changeset detectedLatest commit: cf51a22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@marvinhagemeister @JoviDeCroock Review me please). Its fix for 1.2.1 version, because its most stable one and for now the only one working in react native. |
JoviDeCroock
left a comment
JoviDeCroock
left a comment
There was a problem hiding this comment.
Seems to have a lot of merge conflicts and non-related changes in the lockfile
| @@ -1,243 +1,308 @@ | |||
| lockfileVersion: 5.4 | |||
| lockfileVersion: '6.0' | |||
There was a problem hiding this comment.
I don't think adding the lockfile changes is in scope of this PR
There was a problem hiding this comment.
Sorry but without this changes pipelines was failed
There was a problem hiding this comment.
Then we need to update/alter the pipeline or fix it separately.
There was a problem hiding this comment.
Should I cherry pick and provide another PR? In which branch i should merge it?
Am I understanding you correctly in that this is based on Precisely, is it |
|
I think it should be in another branch, this changes for |
|
I think we can cherry pick commit related with adding tests for forwardRef and lazy. But other things merge into separate branch. |
|
@JoviDeCroock @rschristian what should i do to release 1.2.3 with this fixes? I want to fix this bug, because it causes problems in my project |
|
Sorry for the delay, just been incredibly busy and missed this. I created a new branch from I don't use React and therefore this package, so I can't really comment here. @andrewiggins is probably the best person to comment on this (if he has the time) |
This reverts commit ad9403f.
|
#431 Extracted lockfile changes to separate PR |
|
The CI being limited to PRs against |
|
any updates on this? |
You can use the 2.0.0 version with the babel plugin now |
4 participants
Based on @ywang1724 pr #342. Appreciate for help.
Added tests of reactiveness for
React.lazyandReact.forwardRefand made program to pass it.Updated pnpm-lock while installation, because ci failed