Skip to content

Fix text update recomputing in @preact/signals 1.3.x #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

developit
Copy link
Member

We could have just checked the value against a local variable, but that would leave the computeds re-running unnecessarily.

Note that this would be patch - @preact/[email protected], as main is already at least a minor version ahead (or major).

We could have just checked the value against a local variable, but that would leave the computeds re-running unnecessarily.
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: efc56d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for preact-signals-demo failed.

Name Link
🔨 Latest commit efc56d1
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/673bff75c0384800087df905

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changeset, can look at CI failure later. Signals uses automated publishing but we could do a manual one for this

@developit developit closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants