Skip to content

(signals-react): Remove automatic entrypoint #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-taxis-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@preact/signals-react": major
---

Remove `/auto` and automatic tracking as it is incompatible with React 19
29 changes: 15 additions & 14 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ const pkgList = {
core: "@preact/signals-core",
preact: "@preact/signals",
react: "@preact/signals-react",
"react/auto": "@preact/signals-react/auto",
"react/runtime": "@preact/signals-react/runtime",
"react-transform": "@preact/signals-react-transform",
};
Expand Down Expand Up @@ -304,19 +303,21 @@ module.exports = function (config) {
customLaunchers: localLaunchers,

files: [
...filteredPkgList.some(i => /^react/.test(i)) ? [
{
// Provide some NodeJS globals to run babel in a browser environment
pattern: "test/browser/nodeGlobals.js",
watched: false,
type: "js",
},
{
pattern: "test/browser/babel.js",
watched: false,
type: "js",
},
] : [],
...(filteredPkgList.some(i => /^react/.test(i))
? [
{
// Provide some NodeJS globals to run babel in a browser environment
pattern: "test/browser/nodeGlobals.js",
watched: false,
type: "js",
},
{
pattern: "test/browser/babel.js",
watched: false,
type: "js",
},
]
: []),
{
pattern:
process.env.TESTS ||
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,16 @@
"private": true,
"scripts": {
"prebuild": "shx rm -rf packages/*/dist/",
"build": "pnpm build:core && pnpm build:preact && pnpm build:react-runtime && pnpm build:react-auto && pnpm build:react && pnpm build:react-transform",
"build": "pnpm build:core && pnpm build:preact && pnpm build:react-runtime && pnpm build:react && pnpm build:react-transform",
"_build": "microbundle --raw --globals @preact/signals-core=preactSignalsCore,preact/hooks=preactHooks,@preact/signals-react/runtime=reactSignalsRuntime",
"build:core": "pnpm _build --cwd packages/core && pnpm postbuild:core",
"build:preact": "pnpm _build --cwd packages/preact && pnpm postbuild:preact",
"build:react": "pnpm _build --cwd packages/react --external \"react,@preact/signals-react/runtime,@preact/signals-core\" && pnpm postbuild:react",
"build:react-auto": "pnpm _build --cwd packages/react/auto && pnpm postbuild:react-auto",
"build:react-runtime": "pnpm _build --cwd packages/react/runtime && pnpm postbuild:react-runtime",
"build:react-transform": "pnpm _build --no-compress --cwd packages/react-transform",
"postbuild:core": "cd packages/core/dist && shx mv -f index.d.ts signals-core.d.ts",
"postbuild:preact": "cd packages/preact/dist && shx mv -f preact/src/index.d.ts signals.d.ts && shx rm -rf preact",
"postbuild:react": "cd packages/react/dist && shx mv -f react/src/index.d.ts signals.d.ts && shx rm -rf react",
"postbuild:react-auto": "cd packages/react/auto/dist && shx mv -f react/auto/src/*.d.ts . && shx rm -rf react",
"postbuild:react-runtime": "cd packages/react/runtime/dist && shx mv -f react/runtime/src/*.d.ts . && shx rm -rf react",
"lint": "pnpm lint:eslint && pnpm lint:tsc",
"lint:eslint": "eslint 'packages/**/*.{ts,tsx,js,jsx}'",
Expand Down
25 changes: 0 additions & 25 deletions packages/react/auto/package.json

This file was deleted.

2 changes: 0 additions & 2 deletions packages/react/auto/src/index.ts

This file was deleted.

42 changes: 0 additions & 42 deletions packages/react/auto/test/browser/mounts.test.tsx

This file was deleted.

12 changes: 0 additions & 12 deletions packages/react/auto/test/browser/updates.test.tsx

This file was deleted.

24 changes: 0 additions & 24 deletions packages/react/auto/test/node/renderToStaticMarkup.test.tsx

This file was deleted.

14 changes: 2 additions & 12 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,7 @@
"import": "./runtime/dist/runtime.mjs",
"require": "./runtime/dist/runtime.js"
},
"./runtime/package.json": "./runtime/package.json",
"./auto": {
"types": "./auto/dist/index.d.ts",
"browser": "./auto/dist/auto.module.js",
"import": "./auto/dist/auto.mjs",
"require": "./auto/dist/auto.js"
},
"./auto/package.json": "./auto/package.json"
"./runtime/package.json": "./runtime/package.json"
},
"mangle": "../../mangle.json",
"files": [
Expand All @@ -53,15 +46,12 @@
"runtime/dist",
"runtime/src",
"runtime/package.json",
"auto/dist",
"auto/src",
"auto/package.json",
"CHANGELOG.md",
"LICENSE",
"README.md"
],
"scripts": {
"prepublishOnly": "cd ../.. && pnpm build:react-runtime && pnpm build:react-auto && pnpm build:react"
"prepublishOnly": "cd ../.. && pnpm build:react-runtime && pnpm build:react"
},
"dependencies": {
"@preact/signals-core": "workspace:^1.7.0",
Expand Down
Loading
Loading