Skip to content

Use afterNextFrame for hidden origins #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Conversation

JoviDeCroock
Copy link
Member

When a page is hidden because the user is on a different tab but it received i.e. a webhook we still want effects to run. This PR ensures that by installing a 100ms timeout as animation frames don't run for non-visible pages.

@JoviDeCroock JoviDeCroock requested a review from developit March 26, 2025 06:41
Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: 48cdd8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for preact-signals-demo failed.

Name Link
🔨 Latest commit 48cdd8b
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/67e41b03b53fe900070a2618

Copy link
Contributor

github-actions bot commented Mar 26, 2025

Size Change: -159 B (-0.19%)

Total Size: 83.3 kB

Filename Size Change
docs/dist/assets/index.********.js 836 B -239 B (-22.23%) 🎉
docs/dist/assets/signals.module.********.js 2.22 kB +2 B (+0.09%)
docs/dist/demos-********.js 3.44 kB -2 B (-0.06%)
packages/preact/dist/signals.js 1.54 kB +38 B (+2.53%)
packages/preact/dist/signals.mjs 1.51 kB +42 B (+2.86%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/client.********.js 46.2 kB
docs/dist/assets/jsxRuntime.module.********.js 284 B
docs/dist/assets/preact.module.********.js 4.03 kB
docs/dist/assets/signals-core.module.********.js 1.41 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 243 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.45 kB
packages/core/dist/signals-core.mjs 1.47 kB
packages/react-transform/dist/signals-*********.js 4.93 kB
packages/react-transform/dist/signals-transform.mjs 4.16 kB
packages/react-transform/dist/signals-transform.umd.js 5.04 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit df4df76 into main Mar 26, 2025
2 of 6 checks passed
@JoviDeCroock JoviDeCroock deleted the use-after-next-frame branch March 26, 2025 15:26
@github-actions github-actions bot mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants