-
-
Notifications
You must be signed in to change notification settings - Fork 104
Fix array signals when used as jsx #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 340d736 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +274 B (+0.33%) Total Size: 83.6 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Fixes #665
We forgot that an Array can't be optimised rendered, this is considered not a valid element but also isn't text. We used to catch this with
nodeType
checks https://github.com/preactjs/signals/blob/%40preact/signals%401.3.2/packages/preact/src/index.ts#L97