Skip to content

Fix array signals when used as jsx #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 3, 2025

Fixes #665

We forgot that an Array can't be optimised rendered, this is considered not a valid element but also isn't text. We used to catch this with nodeType checks https://github.com/preactjs/signals/blob/%40preact/signals%401.3.2/packages/preact/src/index.ts#L97

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 340d736

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 340d736
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/67ee99ba8662c600081cb99b
😎 Deploy Preview https://deploy-preview-666--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Size Change: +274 B (+0.33%)

Total Size: 83.6 kB

Filename Size Change
docs/dist/assets/bench.********.js 1.59 kB +2 B (+0.13%)
docs/dist/assets/index.********.js 1.07 kB +239 B (+28.59%) 🚨
docs/dist/assets/signals.module.********.js 2.23 kB +11 B (+0.5%)
docs/dist/demos-********.js 3.44 kB +1 B (+0.03%)
packages/preact/dist/signals.js 1.55 kB +13 B (+0.84%)
packages/preact/dist/signals.mjs 1.52 kB +8 B (+0.53%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.2 kB
docs/dist/assets/jsxRuntime.module.********.js 284 B
docs/dist/assets/preact.module.********.js 4.03 kB
docs/dist/assets/signals-core.module.********.js 1.41 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 243 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.45 kB
packages/core/dist/signals-core.mjs 1.47 kB
packages/react-transform/dist/signals-*********.js 4.93 kB
packages/react-transform/dist/signals-transform.mjs 4.16 kB
packages/react-transform/dist/signals-transform.umd.js 5.04 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

@preactjs preactjs deleted a comment from netlify bot Apr 3, 2025
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@JoviDeCroock JoviDeCroock merged commit f72e769 into main Apr 3, 2025
6 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-array-value-signals branch April 3, 2025 15:44
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX.Element[] valued signals no longer re-render on update after upgrade to 2.0.0
3 participants