[TS] Narrow types for Show utility - #701
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a1e13bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I don't know if I like that. 0n feels more object-y than 0 to me
calebeby
commented
Jun 26, 2025
Downside: It won't correctly handle literal values like "hello" vs "", but oh well.
JoviDeCroock
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is part of my code:
xScalehas the typeReadonlySignal<number[] | null>. The parameterxScalehas the typenumber[] | null, but really its type should benumber[], since the function won't get called for falsy values.Within the
Showcomponent function, thexScaleparameter is known to be truthy, sinceShowwon't run the child unless the signal value is truthy.Before this PR, I get the TS error
'xScale' is possibly 'null'.from right before the.map.After this PR, there are no errors, since the
xScaleparameter excludes falsy types from the original type, so its type is justnumber[] | null.I do not use React but if you would like me to make the same change to the react utils package I would be happy to.
Thanks for signals! I have used preact for a long time but this is my first time using signals and it is so neat! I get a smile on my face every time a render is skipped because signals 😄