Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''
title: ""
labels: ""
assignees: ""
---

- [ ] Check if updating to the latest version resolves the issue

**Environment**

- [ ] I am using `@preact/signals-core`
- [ ] I am using `@preact/signals`
- [ ] I am using `@preact/signals-react`
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
title: ""
labels: feature request
assignees: ''
assignees: ""
---

**Describe the feature you'd love to see**
Expand Down
4 changes: 2 additions & 2 deletions docs/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default defineConfig(env => ({
process.env.DEBUG
? preact({
exclude: /\breact/,
})
})
: null,
multiSpa(["index.html", "demos/**/*.html"]),
unsetPreactAliases(),
Expand Down Expand Up @@ -68,7 +68,7 @@ export default defineConfig(env => ({
// one, as expected. I'm working around this by just mainly aliasing
// the package that needs to be resolved.
"@preact/signals-react/runtime": join(root, "react/runtime"),
}
}
: packages(false),
},
}));
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ module.exports = function (config) {
watched: false,
type: "js",
},
]
]
: []),
{
pattern:
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"microbundle": "^0.15.1",
"mocha": "^10.0.0",
"oxlint": "^1.3.0",
"prettier": "^2.7.1",
"prettier": "^3.6.2",
"shx": "^0.3.4",
"sinon": "^14.0.0",
"sinon-chai": "^3.7.0",
Expand All @@ -98,7 +98,8 @@
]
},
"prettier": {
"arrowParens": "avoid"
"arrowParens": "avoid",
"trailingComma": "es5"
},
"pnpm": {
"patchedDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions packages/react-transform/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -433,10 +433,10 @@ function transformFunction(
const hookUsage = options.experimental?.noTryFinally
? UNMANAGED
: isHook
? MANAGED_HOOK
: isComponent
? MANAGED_COMPONENT
: UNMANAGED;
? MANAGED_HOOK
: isComponent
? MANAGED_COMPONENT
: UNMANAGED;

let newBody: BabelTypes.BlockStatement;
if (hookUsage !== UNMANAGED) {
Expand Down
4 changes: 2 additions & 2 deletions packages/react/test/browser/react-router.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ const Routes = ReactRouter.Routes
const Route = ReactRouter.Routes
? ReactRouter.Route
: // react-router-dom v5 requires the element prop to be passed as children.
({ element, ...props }: any) => (
({ element, ...props }: any) => (
<ReactRouter.Route {...props}>{element}</ReactRouter.Route>
);
);

describe("@preact/signals-react", () => {
let scratch: HTMLDivElement;
Expand Down
11 changes: 9 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.