feat: dispose effect() with resource management - #706
Merged
Conversation
🦋 Changeset detectedLatest commit: 4045d2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: -51 B (-0.06%) Total Size: 87.6 kB
ℹ️ View Unchanged
|
| "stripInternal": true, | ||
| "noUnusedLocals": true, | ||
| "noEmit": true, | ||
| "skipLibCheck": true, |
Member
Author
There was a problem hiding this comment.
Needed to add this because the newer TS version complains about something in sinon types
JoviDeCroock
approved these changes
Jun 28, 2025
JoviDeCroock
left a comment
Member
There was a problem hiding this comment.
That's a great addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for disposing
effect()'s with theusingkeyword from the stage 3 explicit resource management proposal.Needed to update the babel toolchain to support parsing the
usingkeyword in our test setup.