Add signal names - #730
Merged
Merged
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JoviDeCroock
force-pushed
the
add-signal-names
branch
from
August 12, 2025 07:27
d205821 to
3c92116
Compare
Contributor
|
Size Change: +2.91 kB (+3%) Total Size: 100 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Aug 12, 2025
Merged
rschristian
approved these changes
Aug 12, 2025
Closed
JoviDeCroock
force-pushed
the
add-signal-names
branch
from
August 13, 2025 08:01
3c92116 to
9e57c27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #727
We inject a name for every computed/signal we encounter this makes the debugging a lot more convenient, in addition to that this adds a block to every react component so we can track the signals used within it.