Skip to content

Add signal names - #730

Merged
JoviDeCroock merged 2 commits into
mainfrom
add-signal-names
Aug 13, 2025
Merged

Add signal names#730
JoviDeCroock merged 2 commits into
mainfrom
add-signal-names

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Related to #727

We inject a name for every computed/signal we encounter this makes the debugging a lot more convenient, in addition to that this adds a block to every react component so we can track the signals used within it.

@changeset-bot

changeset-bot Bot commented Aug 12, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9e57c27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Aug 12, 2025

Copy link
Copy Markdown

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit d2db645
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/689c46875d067900082b5804
😎 Deploy Preview https://deploy-preview-730--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JoviDeCroock
JoviDeCroock changed the base branch from main to chrome-extension-stuff August 12, 2025 07:26
@github-actions

github-actions Bot commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Size Change: +2.91 kB (+3%)

Total Size: 100 kB

Filename Size Change
packages/react-transform/dist/signals-*********.js 6.89 kB +968 B (+16.33%) ⚠️
packages/react-transform/dist/signals-transform.mjs 6.09 kB +978 B (+19.11%) ⚠️
packages/react-transform/dist/signals-transform.umd.js 7.01 kB +967 B (+16%) ⚠️
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/client.********.js 46.2 kB
docs/dist/assets/index.********.js 6.86 kB
docs/dist/assets/jsxRuntime.module.********.js 297 B
docs/dist/assets/preact.module.********.js 4.72 kB
docs/dist/assets/signals-core.module.********.js 1.56 kB
docs/dist/assets/signals.module.********.js 2.56 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 246 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.59 kB
packages/core/dist/signals-core.mjs 1.6 kB
packages/debug/dist/debug.js 3.48 kB
packages/debug/dist/debug.mjs 3.02 kB
packages/preact/dist/signals.js 1.7 kB
packages/preact/dist/signals.mjs 1.66 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

@JoviDeCroock JoviDeCroock mentioned this pull request Aug 13, 2025
Base automatically changed from chrome-extension-stuff to main August 13, 2025 08:00
@JoviDeCroock
JoviDeCroock merged commit 8423511 into main Aug 13, 2025
6 checks passed
@JoviDeCroock
JoviDeCroock deleted the add-signal-names branch August 13, 2025 08:05
@github-actions github-actions Bot mentioned this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants