Skip to content

Abstract into settings-store and fix component-name assignment - #741

Merged
JoviDeCroock merged 1 commit into
mainfrom
tweaks
Aug 16, 2025
Merged

Abstract into settings-store and fix component-name assignment#741
JoviDeCroock merged 1 commit into
mainfrom
tweaks

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented Aug 15, 2025

Copy link
Copy Markdown
Member

Resolves #739

@changeset-bot

changeset-bot Bot commented Aug 15, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 03f56ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Aug 15, 2025

Copy link
Copy Markdown

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 03f56ba
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/68a02692d6a3200008e28393
😎 Deploy Preview https://deploy-preview-741--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Size Change: -6.05 kB (-6.05%) ✅

Total Size: 94 kB

Filename Size Change
docs/dist/assets/bench.********.js 1.59 kB -2 B (-0.13%)
docs/dist/assets/index.********.js 835 B -6.03 kB (-87.83%) 🏆
packages/debug/dist/debug.js 3.47 kB -13 B (-0.37%)
packages/debug/dist/debug.mjs 3.01 kB -13 B (-0.43%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.2 kB
docs/dist/assets/jsxRuntime.module.********.js 297 B
docs/dist/assets/preact.module.********.js 4.72 kB
docs/dist/assets/signals-core.module.********.js 1.56 kB
docs/dist/assets/signals.module.********.js 2.56 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 246 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.59 kB
packages/core/dist/signals-core.mjs 1.6 kB
packages/preact/dist/signals.js 1.7 kB
packages/preact/dist/signals.mjs 1.66 kB
packages/react-transform/dist/signals-*********.js 6.89 kB
packages/react-transform/dist/signals-transform.mjs 6.09 kB
packages/react-transform/dist/signals-transform.umd.js 7.01 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

Comment thread extension/src/models/ConnectionModel.ts Outdated
const isConnected = signal(false);

const message = computed(() => {
console.log("status", status.value);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a debugging leftover? Ignore me if intentional

Comment on lines 20 to 22
useSignalEffect(() => {
localSettings.value = settings.value;
localSettings.value = settings;
});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this useSignalEffect still right? Looks like settings is no longer a signal & so this won't rerun?

@JoviDeCroock
JoviDeCroock merged commit eb2cd11 into main Aug 16, 2025
6 checks passed
@JoviDeCroock
JoviDeCroock deleted the tweaks branch August 16, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Computed should report the correct component

3 participants