feat(extension): display first component parent in render info - #750
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@JoviDeCroock this is how it looks now:
it shows the first non-text parent if the current node is a text node |
|
@43081j The only issue is that it stopped working in React, in the babel plugin it will still pass the string. Generally though, this looks amazing to me! |
|
do you mean it doesn't show the i've just pushed a small change so if a parent of a text node is a string type, we will still show maybe that helps |
No, React is currently still passing in a string rather than a VNode which makes it crash for me |
|
for future reference - where does that live? the code which is calling |
|
The babel plugin has enterComponent |
6b3fbbe to
2a130a0
Compare
|
ok this should be how you suggested now |

draft for now since we're not sure if we want this yet
something along the lines of this could be useful though, to see what actually rendered. most signals end up in text nodes, so we don't really know the context of the component that actually rendered it. this could help w/ that