Delay subscribing to a component until its fully mounted - #794
Open
JoviDeCroock wants to merge 6 commits into
Open
Delay subscribing to a component until its fully mounted#794JoviDeCroock wants to merge 6 commits into
JoviDeCroock wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: 7b11c8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +142 B (+0.07%) Total Size: 190 kB 📦 View Changed
ℹ️ View Unchanged
|
5 tasks
JoviDeCroock
commented
Nov 12, 2025
JoviDeCroock
force-pushed
the
fix-react-suspense
branch
from
November 12, 2025 19:11
217f16d to
2f22abe
Compare
JoviDeCroock
force-pushed
the
fix-react-suspense
branch
from
January 22, 2026 19:58
2f22abe to
0f25fc0
Compare
JoviDeCroock
force-pushed
the
fix-react-suspense
branch
from
May 18, 2026 16:40
856ec12 to
d10812a
Compare
andrewiggins
approved these changes
Jul 13, 2026
| signal1.value++; | ||
| signal2.value++; | ||
| }); | ||
| expect(Signal.prototype._subscribe).to.equal(originalSubscribe); |
Member
There was a problem hiding this comment.
I appreciate these checks to make sure the original implementation is restored
Assisted-By: devx/e0620a8d-8624-4748-b9c7-ce390238fc37
JoviDeCroock
force-pushed
the
fix-react-suspense
branch
from
July 22, 2026 13:20
c798c94 to
fdae2b7
Compare
Assisted-By: devx/e0620a8d-8624-4748-b9c7-ce390238fc37
JoviDeCroock
force-pushed
the
fix-react-suspense
branch
from
July 22, 2026 13:32
fdae2b7 to
7b11c8d
Compare
marvinhagemeister
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #768
This effectively addresses the "missing lifecycle" problem of React, when React suspends during mount it will discard any in progress work which means that the store won't be disposed and hence the subscriptions/... won't be discarded. We circumvent this by overriding the Signal
_subscribemethod, which sets up the subscriptions, to track all subscriptions for a store and only subscribe them when we are sure the component is fully mounted. This prevents us from subscribing on a work-in-progress state which will just be discarded.Why do I think this is breaking? React already has a rule not to setState during render but we can't be sure everyone expects that, hence we are marking this as breaking. No synchronous work should be able to intervene during component rendering hence this forking of
Signal.prototype._subscribeis safe as long as we ensure it's restored in the end.Thanks to the finally cleaning up with store.f() we are sure this restoration happens correctly. In the manual unmamaged one we might have patterns where we don't which I am fine with due to this being a major bump.
TODO:
Signal.prototype._subscribeis restored to its initial form