Skip to content

Extract key from child-element#909

Open
JoviDeCroock wants to merge 1 commit intomainfrom
extract-key
Open

Extract key from child-element#909
JoviDeCroock wants to merge 1 commit intomainfrom
extract-key

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock commented Mar 29, 2026

Follow up to #907 CC @jbalsas

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 29, 2026

🦋 Changeset detected

Latest commit: 424ef9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@preact/signals Patch
@preact/signals-react Patch
preact-signals-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 29, 2026

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 424ef9f
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/69c8cd52723cc50008f71f64
😎 Deploy Preview https://deploy-preview-909--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JoviDeCroock JoviDeCroock requested a review from developit March 29, 2026 06:57
@github-actions
Copy link
Copy Markdown
Contributor

Size Change: +72 B (+0.04%)

Total Size: 184 kB

📦 View Changed
Filename Size Change
docs/dist/assets/devtools-********.js 914 B +1 B (+0.11%)
docs/dist/assets/index-********.js 8.38 kB -1 B (-0.01%)
docs/dist/assets/utils.module-********.js 526 B +72 B (+15.86%) ⚠️
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench-********.js 1.6 kB
docs/dist/assets/client-********.js 46.6 kB
docs/dist/assets/EmbeddedDevtools-********.js 16.6 kB
docs/dist/assets/jsxRuntime.module-********.js 300 B
docs/dist/assets/preact.module-********.js 4.74 kB
docs/dist/assets/signals-core.module-********.js 1.89 kB
docs/dist/assets/signals.module-********.js 2.64 kB
docs/dist/assets/style-********.css 5.26 kB
docs/dist/assets/Unmount-********.js 652 B
docs/dist/basic-********.js 249 B
docs/dist/nesting-********.js 1.15 kB
docs/dist/react-********.js 243 B
packages/core/dist/signals-core.js 1.92 kB
packages/core/dist/signals-core.mjs 1.91 kB
packages/debug/dist/debug.js 4.58 kB
packages/debug/dist/debug.mjs 4.09 kB
packages/devtools-adapter/dist/devtools-adapter.js 2.17 kB
packages/devtools-adapter/dist/devtools-adapter.mjs 1.88 kB
packages/devtools-ui/dist/devtools-ui.js 15.2 kB
packages/devtools-ui/dist/devtools-ui.mjs 14.7 kB
packages/preact-transform/dist/signals-transform.js 1.3 kB
packages/preact-transform/dist/signals-transform.mjs 1.29 kB
packages/preact-transform/dist/signals-transform.umd.js 1.42 kB
packages/preact/dist/signals.js 1.81 kB
packages/preact/dist/signals.mjs 1.75 kB
packages/react-transform/dist/signals-transform.js 7.28 kB
packages/react-transform/dist/signals-transform.mjs 6.47 kB
packages/react-transform/dist/signals-transform.umd.js 7.39 kB
packages/react/dist/signals.js 214 B
packages/react/dist/signals.mjs 165 B
packages/vite-plugin/dist/vite-plugin.js 8.86 kB
packages/vite-plugin/dist/vite-plugin.mjs 7.86 kB

compressed-size-action

Copy link
Copy Markdown
Contributor

@jbalsas jbalsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Is there no way we could do this without having to wrap the passed in children in <Item> but still keep the scoped reactivity to the items? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants