Skip to content

fix(core): prevent model effect capture in untracked - #945

Merged
andrewiggins merged 3 commits into
mainfrom
fix-model-effect-untracked-action-capture
Jun 17, 2026
Merged

fix(core): prevent model effect capture in untracked#945
andrewiggins merged 3 commits into
mainfrom
fix-model-effect-untracked-action-capture

Conversation

@andrewiggins

@andrewiggins andrewiggins commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Prevent untracked() from propagating ambient createModel() effect capture into its callback
  • Ensure action() callbacks get the same behavior because action() delegates to untracked()
  • Add coverage for untracked(), action(), and nested model ownership boundaries

Co-authored by: Pi coding agent & GPT 5.5

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e823769

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@preact/signals-core Patch
preact-signals-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jun 16, 2026

Copy link
Copy Markdown

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit e823769
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/6a31da34cf1f1b0008924e7d
😎 Deploy Preview https://deploy-preview-945--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Size Change: -7.51 kB (-4.01%)

Total Size: 180 kB

📦 View Changed
Filename Size Change
docs/dist/assets/client-********.js 46.6 kB +2 B (0%)
docs/dist/assets/devtools-********.js 908 B +4 B (+0.44%)
docs/dist/assets/EmbeddedDevtools-********.js 17.7 kB +8 B (+0.05%)
docs/dist/assets/index-********.js 837 B -7.59 kB (-90.06%) 🏆
docs/dist/assets/signals-core.module-********.js 1.89 kB +11 B (+0.59%)
docs/dist/assets/Unmount-********.js 650 B +3 B (+0.46%)
docs/dist/assets/utils.module-********.js 500 B +2 B (+0.4%)
docs/dist/nesting-********.js 1.14 kB +1 B (+0.09%)
packages/core/dist/signals-core.js 1.92 kB +13 B (+0.68%)
packages/core/dist/signals-core.mjs 1.91 kB +12 B (+0.63%)
packages/devtools-ui/dist/devtools-ui.js 16.2 kB +11 B (+0.07%)
packages/devtools-ui/dist/devtools-ui.mjs 15.6 kB +10 B (+0.06%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench-********.js 1.6 kB
docs/dist/assets/jsxRuntime.module-********.js 300 B
docs/dist/assets/preact.module-********.js 4.74 kB
docs/dist/assets/signals.module-********.js 2.65 kB
docs/dist/assets/style-********.css 5.26 kB
docs/dist/basic-********.js 245 B
docs/dist/react-********.js 243 B
packages/debug/dist/debug.js 4.64 kB
packages/debug/dist/debug.mjs 4.15 kB
packages/devtools-adapter/dist/devtools-adapter.js 2.36 kB
packages/devtools-adapter/dist/devtools-adapter.mjs 2.07 kB
packages/preact-transform/dist/signals-transform.js 1.3 kB
packages/preact-transform/dist/signals-transform.mjs 1.29 kB
packages/preact-transform/dist/signals-transform.umd.js 1.42 kB
packages/preact/dist/signals.js 1.81 kB
packages/preact/dist/signals.mjs 1.75 kB
packages/react-transform/dist/signals-transform.js 7.28 kB
packages/react-transform/dist/signals-transform.mjs 6.47 kB
packages/react-transform/dist/signals-transform.umd.js 7.39 kB
packages/react/dist/signals.js 214 B
packages/react/dist/signals.mjs 165 B
packages/vite-plugin/dist/vite-plugin.js 8.86 kB
packages/vite-plugin/dist/vite-plugin.mjs 7.86 kB

compressed-size-action

Comment thread .husky/pre-commit
@andrewiggins
andrewiggins merged commit d40746b into main Jun 17, 2026
6 checks passed
@andrewiggins
andrewiggins deleted the fix-model-effect-untracked-action-capture branch June 17, 2026 21:02
@github-actions github-actions Bot mentioned this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants