[DRAFT] - cjs module transforms - #168
Closed
JoviDeCroock wants to merge 4 commits into
Closed
Conversation
Contributor
|
Size Change: 0 B Total Size: 679 kB ℹ️ View Unchanged
|
developit
reviewed
Nov 11, 2020
| import sassPlugin from './plugins/sass-plugin.js'; | ||
| import processGlobalPlugin from './plugins/process-global-plugin.js'; | ||
| import { getMimeType } from './lib/mimetypes.js'; | ||
| import fastCjsPlugin from './plugins/fast-cjs-plugin.js'; |
Member
There was a problem hiding this comment.
I'm wondering if it'd be easier to have transformRequires() just be part of fastCjsPlugin? Right now this PR disables CommonJS in prod I think.
4 tasks
| console.log(h); | ||
| exports.Test = 'test2'; | ||
|
|
||
| module.exports = 'test'; |
Member
There was a problem hiding this comment.
Is this really something that should be allowed? Breaks in node
Member
Author
|
I'll try redo'ing this PR, it's gotten a bit outdated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my initial attempt at implementing cjs-module-lexer, ... I couldn't get the tests to run properly on my windows machine so I'm going to defer this for when I'm at my MBP.