Skip to content

MobileFuse Adapter: Remove tagid_src and pub_id params #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 10 commits into from
Jul 1, 2025
Merged

MobileFuse Adapter: Remove tagid_src and pub_id params #3915

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
76a61bb
Remove tagid_src ext from MobileFuse Adapter
tomaszbmf Apr 16, 2025
9d48692
remove pub_id query param
tomaszbmf Apr 22, 2025
64b827f
fix unit tests
tomaszbmf Apr 22, 2025
695d694
clean up redundant code which obtains endpoint url
tomaszbmf May 13, 2025
2c22211
remove impExt null check
tomaszbmf May 16, 2025
185fc06
Merge branch 'prebid:master' into mobilefuse-remove-tagid-src-ext
tomaszbmf May 19, 2025
3033451
Restore validation for missing ExtImpMobilefuse
tomaszbmf May 19, 2025
9d59b8a
Merge branch 'prebid:master' into mobilefuse-remove-tagid-src-ext
tomaszbmf May 28, 2025
5d4c0d6
Align with Golang implementation
tomaszbmf May 28, 2025
14153c4
remove throws and reorder methods
tomaszbmf Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/org/prebid/server/bidder/mobilefuse/MobilefuseBidder.java
View file
Open in desktop
Copy link
Collaborator

@CTMBNara CTMBNara Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorder the methods so that they are placed in the order they are called

Copy link
Contributor Author

@tomaszbmf tomaszbmf Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied both changes

Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ private ObjectNode parseSkadn(ObjectNode impExt) {
}

private String makeUrl(ExtImpMobilefuse extImp) {
final String baseUrl = endpointUrl + Objects.toString(extImp.getPublisherId(), "0");
return "ext".equals(extImp.getTagidSrc()) ? baseUrl + "&tagid_src=ext" : baseUrl;
return endpointUrl;
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you don't the following part of code as well

        final String endpoint = request.getImp().stream()
                .map(this::parseImpExt)
                .filter(Objects::nonNull)
                .findFirst()
                .map(this::makeUrl)
                .orElse(null);

please clean up redundant code

Copy link
Contributor Author

@tomaszbmf tomaszbmf May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out! I've removed the redundant code as suggested.

To ensure stability after removing the .map(this::parseImpExt).filter(Objects::nonNull) chain, I added a null check in the modifyImp(Imp imp) method. This prevents a potential NullPointerException in cases where parseImpExt could return null.

Let me know if there's anything else you'd like me to update!

}

@Override
Expand Down
6 changes: 0 additions & 6 deletions src/main/java/org/prebid/server/proto/openrtb/ext/request/mobilefuse/ExtImpMobilefuse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,4 @@ public class ExtImpMobilefuse {

@JsonProperty("placement_id")
Integer placementId;

@JsonProperty("pub_id")
Integer publisherId;

@JsonProperty("tagid_src")
String tagidSrc;
}
2 changes: 1 addition & 1 deletion src/main/resources/bidder-config/mobilefuse.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
adapters:
mobilefuse:
endpoint: http://mfx.mobilefuse.com/openrtb?pub_id=
endpoint: http://mfx.mobilefuse.com/openrtb
ortb-version: "2.6"
endpoint-compression: gzip
# This bidder does not operate globally. Please consider setting "disabled: true" outside of the following regions:
Expand Down
11 changes: 1 addition & 10 deletions src/main/resources/static/bidder-params/mobilefuse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,9 @@
"placement_id": {
"type": "integer",
"description": "An ID which identifies this specific inventory placement"
},
"pub_id": {
"type": "integer",
"description": "An ID which identifies the publisher selling the inventory."
},
"tagid_src": {
"type": "string",
"description": "ext if passing publisher's ids, empty if passing MobileFuse IDs in placement_id field. Defaults to empty"
}
},
"required": [
"placement_id",
"pub_id"
"placement_id"
]
}
46 changes: 4 additions & 42 deletions src/test/java/org/prebid/server/bidder/mobilefuse/MobilefuseBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@

public class MobilefuseBidderTest extends VertxTest {

private static final String ENDPOINT_URL = "https://test.endpoint.com/openrtb?pub_id=";
private static final String ENDPOINT_URL = "https://test.endpoint.com/openrtb";

private final MobilefuseBidder target = new MobilefuseBidder(ENDPOINT_URL, jacksonMapper);

private static Imp givenImp(Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer) {
return impCustomizer.apply(Imp.builder()
.id("imp_id")
.ext(mapper.valueToTree(ExtPrebid.of(null,
ExtImpMobilefuse.of(1, 2, "tagidSrc")))))
ExtImpMobilefuse.of(1)))))
.build();
}

Expand Down Expand Up @@ -102,44 +102,6 @@ public void creationShouldFailOnInvalidEndpointUrl() {
.isThrownBy(() -> new MobilefuseBidder("invalid_url", jacksonMapper));
}

@Test
public void makeHttpRequestsShouldCreateCorrectURLWhenTagidSrcEqualsExt() {
// given
final BidRequest bidRequest = givenBidRequest(
impBuilder -> impBuilder
.banner(Banner.builder().build())
.ext(mapper.valueToTree(ExtPrebid.of(null,
ExtImpMobilefuse.of(1, 2, "ext")))));

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.extracting(HttpRequest::getUri)
.containsExactly("https://test.endpoint.com/openrtb?pub_id=2&tagid_src=ext");
}

@Test
public void makeHttpRequestsShouldSetPubIdToZeroIfPublisherIdNotPresentInRequest() {
// given
final BidRequest bidRequest = givenBidRequest(
impBuilder -> impBuilder
.banner(Banner.builder().build())
.ext(mapper.valueToTree(ExtPrebid.of(null,
ExtImpMobilefuse.of(1, null, null)))));

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.extracting(HttpRequest::getUri)
.containsExactly("https://test.endpoint.com/openrtb?pub_id=0");
}

@Test
public void makeHttpRequestsShouldReturnErrorIfNoValidImpsFound() {
// given
Expand Down Expand Up @@ -193,7 +155,7 @@ public void makeHttpRequestsShouldModifyImpTagId() {
.banner(Banner.builder().build())
.tagid("some tag id")
.ext(mapper.valueToTree(ExtPrebid.of(null,
ExtImpMobilefuse.of(1, 2, "ext")))));
ExtImpMobilefuse.of(1)))));

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
Expand All @@ -212,7 +174,7 @@ public void makeHttpRequestsShouldModifyImpWithAddingSkadnWhenSkadnIsPresent() {
// given
final ObjectNode skadn = mapper.createObjectNode().put("something", "something");
final ObjectNode impExt = mapper.createObjectNode();
impExt.set("bidder", mapper.valueToTree(ExtImpMobilefuse.of(1, 2, "ext")));
impExt.set("bidder", mapper.valueToTree(ExtImpMobilefuse.of(1)));
impExt.set("skadn", skadn);
final BidRequest bidRequest = givenBidRequest(
impBuilder -> impBuilder.banner(Banner.builder().build()).ext(impExt));
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/prebid/server/it/MobilefuseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class MobilefuseTest extends IntegrationTest {
@Test
public void openrtb2AuctionShouldRespondWithBidsFromMobilefuse() throws IOException, JSONException {
// given
WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/mobilefuse-exchange/1111&tagid_src=ext"))
WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/mobilefuse-exchange/"))
.withRequestBody(equalToJson(jsonFrom("openrtb2/mobilefuse/test-mobilefuse-bid-request.json")))
.willReturn(aResponse().withBody(jsonFrom("openrtb2/mobilefuse/test-mobilefuse-bid-response.json"))));

Expand Down
4 changes: 1 addition & 3 deletions ...t/resources/org/prebid/server/it/openrtb2/mobilefuse/test-auction-mobilefuse-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
"tagid": "tag_id",
"ext": {
"mobilefuse": {
"placement_id": 999999,
"pub_id": 1111,
"tagid_src": "ext"
"placement_id": 999999
}
}
}
Expand Down
Loading