-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New Adapter: Adoppler/ElementaTv: #6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pavel-ptashyts
wants to merge
8
commits into
prebid:master
Choose a base branch
from
pavel-ptashyts:adoppler_to_elemental_rename_and_refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−8
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f5fb350
Update Adoppler/ElementaTv:
pavel-ptashyts 004ed83
Update Adoppler/ElementaTv:
pavel-ptashyts 499abe1
Update Adoppler/ElementaTv:
pavel-ptashyts d3c5433
Update Adoppler/ElementaTv:
pavel-ptashyts 915aaf4
Update Adoppler/ElementaTv:
pavel-ptashyts e19b6a0
Update Adoppler/ElementaTv:
pavel-ptashyts 0965c41
Update Adoppler/ElementaTv
pavel-ptashyts baebd0f
Update Adoppler/ElementaTv
pavel-ptashyts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,24 @@ | ||
| --- | ||
| layout: bidder | ||
| title: Adoppler | ||
| pbs: true | ||
| media_types: video | ||
| description: This bidder has been renamed to ElementalTV. | ||
| biddercode: adoppler | ||
| pbs: true | ||
| pbjs: false | ||
| sidebarType: 1 | ||
| --- | ||
|
|
||
| ### Bid Params | ||
| ### Deprecated | ||
|
|
||
| The **Adoppler** bidder has been renamed to **ElementalTV**. | ||
|
|
||
| Please use the **ElementalTV** bidder documentation and biddercode going forward: | ||
|
|
||
| - **Docs:** `/dev-docs/bidders/elementaltv.html` | ||
| - **Bidder code:** `elementaltv` | ||
|
|
||
| ### Notes | ||
|
|
||
| {: .table .table-bordered .table-striped } | ||
| | Name | Scope | Description | Example | Type | | ||
| |------------|----------|------------------------|---------|----------| | ||
| | adunit | required | AdUnit to bid against | 'test' | string | | ||
| | client | optional | Client name | 'ads' | string | | ||
| - `adoppler` is maintained as an alias for backward compatibility. | ||
| - New integrations should use `elementaltv`. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| layout: bidder | ||
| title: ElementalTV | ||
| description: Prebid ElementalTV Bidder Adapter | ||
| biddercode: elementaltv | ||
| pbs: true | ||
| pbjs: false | ||
| media_types: banner, video, native | ||
| pbs_app_supported: true | ||
| schain_supported: true | ||
| coppa_supported: true | ||
| deals_supported: true | ||
| usp_supported: true | ||
| gpp_supported: true | ||
| dsa_supported: false | ||
| multiformat_supported: will-bid-on-any | ||
| sidebarType: 1 | ||
| --- | ||
|
|
||
| ### Registration | ||
|
|
||
| The ElementalTV bidder adapter requires prior setup. Please contact us at <[email protected]>. | ||
|
|
||
| ### OpenRTB Version | ||
|
|
||
| References to the OpenRTB specification in this document assume **OpenRTB 2.6**. | ||
|
|
||
| ### Prebid Server Bid Params | ||
|
|
||
| {: .table .table-bordered .table-striped } | ||
| | Name | Scope | Description | Example | Type | | ||
| |---------|----------|----------------------------------------------|--------------|----------| | ||
| | `adunit`| required | Ad Unit ID or Supply Source reference to bid against | `'test'` or `'SSP:12345'` | `string` | | ||
|
|
||
| ### Notes | ||
|
|
||
| - `adunit` can reference either: | ||
| - an **Ad Unit ID** (pass the ID as-is), or | ||
| - a **Supply Source reference** using the prefix format `SSP:<supply_source_id>` (e.g., `SSP:12345`). | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
gpp_sidsto delcare what regulations you support.https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter
Possible:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Added gpp_sids