Makefile improvements: compiler paths and version-aware flags #139
Conversation
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/simulation-is-stuck-during-setup-calculix-adapter/2423/1 |
|
@abzrg apologies for not looking into this PR sooner. We recently removed yaml-cpp as a dependency. Can you please update your feature branch with respect to the develop branch? I will then review it. |
Also removed `-lstdc++` from `LIBS`
`clang` causes compilation errors if these flags are not enabled: `CFLAGS += -Wno-implicit-function-declaration` Suppresses warnings about using functions without declaring them first `CFLAGS += -Wno-incompatible-pointer-types` Suppresses warnings when assigning or passing pointers between incompatible types (e.g., assigning a char ** to a void **)
- `$(INCLUDES)` is already included in `$(CFLAGS)` - `$(LIBS)` only generate linker warnings
Specifically `-std=c++11` required by yaml-cpp 0.6.0+ (https://github.com/jbeder/yaml-cpp/wiki/Breaking-Changes#060)
abzrg
force-pushed
the
feature-update-makefile
branch
from
d0533a1 to
36149f9
Compare
|
Thank you @IshaanDesai for letting me know. I rebased my changes on the latest changes of |
abzrg
force-pushed
the
feature-update-makefile
branch
from
86ec606 to
1a58657
Compare
MakisH
changed the title
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Thank you for the update! This is a very useful contribution, independent of the original reason (yaml-cpp was removed in #143).
I like the version-aware -fallow-argument-mismatch, which saves the whole hard-coding. We should also update the documentation and the respective CI scripts to remove that (I will do).
5 participants
Hi,
This is a PR based on this discussion. The main goal is to update
:/Makefileso that the adapter can be built on macOS as well.In short, the adaptor couldn't link against
yaml-cpp, because the compilation was done usinggcc,g++and-lstdc++. Changing these toclang,clang++, and-lc++fixed that.Other compilation issues encountered included: