Improve running icons readability #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to improve readability of the running icons.
Alternative color
Author
|
Hello @4lex4 👋 What do you think about this PR? |
Author
|
Hello @4lex4 👋 I hope you are well 🙂 Sorry to bother you, when you have the time, can you look at this tiny pull request? 👀 The last two commits can be drop if you don't like the changes in them. If you want to keep them, just fixup them 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to use the panel color to improve running icons contrast and to improve readability
All of this changes are totally optional and can be drop as you wish 😃
Running icons
The third commit requires to be dropped or fixup to the second one.
It is just a proposal of an alternative color for dark theme that looks better IMO.
Before
After
Alternative dark color (better IMO)
Default button
I also improve a little bit the contrast of the default pop button.
If you don't like it, just drop the commit 😉
Before
After