Skip to content

Conversation

@rintcius
Copy link
Contributor

... also rename because we can't assume these are always auth errors

... also rename because we can't assume these are always auth errors
@rintcius
Copy link
Contributor Author

Changing because of SRV-56
This is not intended to fix the issue yet - just want to propagate the underlying exception for now, so that we can see what's the actual problem

Copy link
Contributor

@domaspoliakas domaspoliakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to just gracefully error, or are we expecting to be recovering from these downstream as well?

@rintcius
Copy link
Contributor Author

Is the intention to just gracefully error, or are we expecting to be recovering from these downstream as well?

We're intermittently seeing Error.Authentication failures. At least some of these don’t appear to be actual authentication issues - but since the underlying exception is currently swallowed, we don’t have more detail.

The plan is to run this change in prod for a while to log the underlying exceptions and gather more information. Based on what we find, we can adjust the handling accordingly - I expect some of these errors will be retriable.

@rintcius rintcius merged commit 0851324 into main Nov 25, 2025
6 checks passed
@rintcius rintcius deleted the auth2 branch November 25, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants