Skip to content

fix: Support kernels with shape 29568#771

Closed
jeffkinnison wants to merge 1 commit intomainfrom
add-shape-29568
Closed

fix: Support kernels with shape 29568#771
jeffkinnison wants to merge 1 commit intomainfrom
add-shape-29568

Conversation

@jeffkinnison
Copy link
Contributor

No description provided.

@jeffkinnison jeffkinnison requested review from arnavgarg1 and Copilot May 1, 2025 23:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for a new kernel shape of 29568 in the bgmv configuration.

  • Added support for kernel shape 29568 in the configuration macros
  • Ensured that the new kernel shape is integrated with existing kernel definitions

f(T, narrow, 27392) \
f(T, narrow, 27648) \
f(T, narrow, 28672) \
f(T, narrow, 29568) \
Copy link

Copilot AI May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment explaining the rationale behind adding the kernel shape 29568 to improve maintainability and for clarity for future developers.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants