feat: allow searching for specific package versions using matchspec #3565
+93
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Apr 11, 2025
|
|
||
| if packages.is_empty() { | ||
| let normalized_package_name = package_name_search.as_normalized(); | ||
| return Err(miette::miette!("Package {normalized_package_name} not found, please use a wildcard '*' in the search name for a broader result.")); |
There was a problem hiding this comment.
Does that actually work?
There was a problem hiding this comment.
If yes, please add a test for it :)
There was a problem hiding this comment.
Hi, I moved this error message up unchanged from line 245 in order to differentiate between the package itself not being found and the match spec not matching. I did not implement providing a match spec for the wildcard search, only the exact one. Do you think the error message is now misleading in that regard? I'm happy to adjust it if you have suggestions for the wording. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #3173
I allowed specifying a MatchSpec for the exact search so that for example
pixi search "rattler-build<=0.35.4"pixi search "rattler-build[build=h3ab7716_0]"are valid search calls and yield the respective package versions.
I added the examples from the issue to the search_extender docs.
I added a test case in
search_tests.rsfor this feature.