fix(publish): keep the server path prefix in upload URLs - #6692
Open
hunger wants to merge 1 commit into
Open
Conversation
`pixi publish --target-channel artifactory://host/artifactory/repo` uploaded to
`https://host/repo/<subdir>/<pkg>` and got a 404: the channel was taken from the
last path segment and the rest of the path was then cleared with `set_path("")`.
JFrog Artifactory serves repositories under an `/artifactory` prefix, so that
prefix is part of the server URL, not something to discard.
Keep every segment before the channel as the server's base path, with a trailing
slash so rattler_upload's `Url::join` appends rather than replaces, and share the
split between the artifactory, quetz and prefix backends, which all had the same
lossy logic. Credential lookup is unaffected: rattler_networking matches non-S3
URLs on the host alone.
The three 'missing channel name' errors now show the expected URL shape, and the
docs and CLI help spell out that a path prefix belongs in the URL.
Fixes prefix-dev#6622
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pixi publish --target-channel artifactory://host/artifactory/repouploaded tohttps://host/repo/<subdir>/<pkg>and got a 404: the channel was taken from the last path segment and the rest of the path was then cleared withset_path(""). JFrog Artifactory serves repositories under an/artifactoryprefix, so that prefix is part of the server URL, not something to discard.Keep every segment before the channel as the server's base path, with a trailing slash so rattler_upload's
Url::joinappends rather than replaces, and share the split between the artifactory, quetz and prefix backends, which all had the same lossy logic. Credential lookup is unaffected: rattler_networking matches non-S3 URLs on the host alone.The three 'missing channel name' errors now show the expected URL shape, and the docs and CLI help spell out that a path prefix belongs in the URL.
Fixes #6622
AI Disclosure
Tools: Claude
Checklist:
schema/model.py.