-
Notifications
You must be signed in to change notification settings - Fork 10
fix context variables bug, add test for variants in sources #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -125,7 +125,7 @@ def render(template: str | list[str], context: dict[str, str]) -> str | list[str | |||
if isinstance(template, list): | |||
return [cast(str, render(t, context)) for t in template] | |||
template = env.from_string(template) | |||
return template.render(context_variables) | |||
return template.render(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was actually a bug?
@wolfv any updates here? |
(was already disabled in testing)
@wolfv, could you approve the workflows again? I didn't change anything about the non-mypy tests from the last CI run, they worked just fine locally... |
The CI should go through now. Since you @minrk correctly pointed out that the tests run through without the modification, let's still keep the bug fix and the additional test. |
Currently,
render_all_sources
does not render variables in source URLs defined by variant variables (as opposed to variables defined in the source section). However, rattler-build supports variant variables in the source section (see, e.g., https://github.com/conda-forge/polars-feedstock/pull/303/checks?check_run_id=35876450902).Does it make sense to support variant variables here too? This would enable the autotick-bot to parse such recipes.