fix context variables bug, add test for variants in sources #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytausch
commented
Jan 22, 2025
ytausch
commented
Jan 22, 2025
| @@ -125,7 +125,7 @@ def render(template: str | list[str], context: dict[str, str]) -> str | list[str | |||
| if isinstance(template, list): | |||
| return [cast(str, render(t, context)) for t in template] | |||
| template = env.from_string(template) | |||
| return template.render(context_variables) | |||
| return template.render(context) | |||
There was a problem hiding this comment.
I think this was actually a bug?
|
@wolfv any updates here? |
(was already disabled in testing)
ytausch
commented
May 14, 2025
|
@wolfv, could you approve the workflows again? I didn't change anything about the non-mypy tests from the last CI run, they worked just fine locally... |
ytausch
changed the title
|
The CI should go through now. Since you @minrk correctly pointed out that the tests run through without the modification, let's still keep the bug fix and the additional test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
render_all_sourcesdoes not render variables in source URLs defined by variant variables (as opposed to variables defined in the source section). However, rattler-build supports variant variables in the source section (see, e.g., https://github.com/conda-forge/polars-feedstock/pull/303/checks?check_run_id=35876450902).Does it make sense to support variant variables here too? This would enable the autotick-bot to parse such recipes.