Normalize line endings in noarch packages for reproducibility#2193
Open
Normalize line endings in noarch packages for reproducibility#2193
Conversation
For `noarch: generic` and `noarch: python` packages, text files are now copied with CRLF line endings converted to LF. This ensures that packages built on Windows produce identical output to those built on Unix, which is required for reproducible builds. Fixes #837 https://claude.ai/code/session_01JwVrTPt44TBuDuNtAYvgW5
Replace the empty `if` branch (clippy::needless_if) with a negated condition, and merge the three separate copy_with_normalized_line_endings tests into one terse parameterised test. https://claude.ai/code/session_01JwVrTPt44TBuDuNtAYvgW5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds line ending normalization for noarch packages to ensure reproducible builds across Windows and Unix platforms. Text files in noarch packages now have CRLF line endings converted to LF, while binary files remain unchanged.
Key Changes
Added
copy_with_normalized_line_endings()function that:\r\n) to LF (\n) for text filesModified
write_to_dest()to use the new normalization function forPlatform::NoArchpackages while preserving existing behavior for platform-specific packagesAdded comprehensive test coverage:
test_copy_with_normalized_line_endings_text: Verifies CRLF→LF conversiontest_copy_with_normalized_line_endings_binary_unchanged: Ensures binary files are not modifiedtest_copy_with_normalized_line_endings_lf_unchanged: Confirms LF-only files remain unchangedImplementation Details
content_inspectorcrate to intelligently detect text vs. binary files by inspecting the first 1024 bytesnoarchpackages (both generic and Python variants) to avoid affecting platform-specific buildsnoarch: genericornoarch: pythonshould have the unix line ending #837 regarding reproducibility across Windows and Unix buildshttps://claude.ai/code/session_01JwVrTPt44TBuDuNtAYvgW5