fix: add missing label to MissingField error in script parser#2233
Open
Hassnaa9 wants to merge 1 commit intoprefix-dev:mainfrom
Open
fix: add missing label to MissingField error in script parser#2233Hassnaa9 wants to merge 1 commit intoprefix-dev:mainfrom
Hassnaa9 wants to merge 1 commit intoprefix-dev:mainfrom
Conversation
Author
|
@swarnimarun Can you review this when you have time please? |
wolfv
reviewed
Mar 6, 2026
| *self.span(), | ||
| ErrorKind::MissingField(Cow::Owned(name.to_owned())) | ||
| ErrorKind::MissingField(Cow::Owned(name.to_owned())), | ||
| label = format!("required field `{}` is missing", name) |
Member
There was a problem hiding this comment.
Is this message a lot better than what we're currently seeing?
Member
|
Can you show the improvement e.g. with a screenshot? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the work started in #398 and #805 to improve
_partialerror!diagnostic messages throughout the codebase.
This PR adds a missing
labelto theMissingFielderror insrc/recipe/parser/script.rs, making it clearer to users which requiredfield is absent when parsing a recipe script section.
Fixes #399