Fix Db_Abstract E_STRICT errors (issue #41) #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
an interface with static functions still makes no sense |
|
alle static methods of the DB Abstract method should be made non-static and therefore all the subclasses need to be adjusted accordingly. |
Author
|
I agree that all static methods shouldn't be static. But it was a first step to introduce the db layer. Like preinheimer said before must of the code is kinda messy and probably need a good cleanup, just time missing. Need to check was excalty change to remove the static methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstract static methods raise E_STRICT errors since php 5.2. Created an interface.