Skip to content

feat: Favicon Fallback Handling & Offline Icon Support #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rudresh-11 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Favicon Fallback Handling & Offline Icon Support #99

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4b881b
updated shortcut.js
Rudresh-11 Dec 4, 2025
3d87fba
updated changelog.md
Rudresh-11 Dec 4, 2025
a4308e1
fixed changelog.md
Rudresh-11 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Translation updated for:
- Japanese ([@kons10](https://github.com/kons10))
- Arabic ([@heshamoomar](https://github.com/heshamoomar))

### Improved
- Improved favicon loading reliability by switching to modern Google favicon endpoint.
- Enhanced offline icon display logic for shortcuts.

## [v3.3](https://github.com/prem-k-r/MaterialYouNewTab/compare/v3.2...v3.3) - Nov 23, 2025

Expand Down
12 changes: 9 additions & 3 deletions scripts/shortcuts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,15 @@ document.addEventListener("DOMContentLoaded", function () {
return preset.svg;
}

// Fetch favicon from Google
return `<img src="https://s2.googleusercontent.com/s2/favicons?domain_url=https://${hostname}&sz=256"
onerror="this.src='./svgs/offline.svg'" alt="">`;
const faviconUrl = `https://unavatar.io/${hostname}?fallback=false`;

return `
<img src="${faviconUrl}"
alt=""
class="favicon-img"
onerror="this.src='./svgs/offline.svg'; this.onerror=null;"
>
`;
}

// Attaches event listeners to shortcut input fields
Expand Down