Unify Architectures, Fix Aliases #2591
Merged
+106
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclark2016
force-pushed
the
architecture-valid-values-unificiation
branch
from
e4fba55 to
5638ce4
Compare
samsinsane
approved these changes
Jan 5, 2026
Jarod42
reviewed
Jan 5, 2026
| platforms { "ARM" } | ||
|
|
||
| filter { "system:windows", "options:arch=ARM64" } | ||
| filter { "system:windows", "options:arch=AARCH64" } |
Contributor
There was a problem hiding this comment.
Shouldn't those filters check both ARM64 or AARCH64?(as there are the "same").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
i386- This should strictly be the original x86 architecture and mean-m32 -march=i386instead of an alias to-m32. This can be reintroduced as its own architecture in the future after deprecation period.x32- This should be-mx32for the x32 ABI. Currently, this maps to-m32which is the x86 ABI, and thus is incorrect.How does this PR change Premake's behavior?
No breaking changes to core. Third party libraries relying on
ARM64rather thanAARCH64will break.Anything else we should know?
Preparation for 5.0
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!