feat(dataReducer): revert merged data removal #324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 89.98% 90.00% +0.01%
==========================================
Files 19 19
Lines 629 630 +1
==========================================
+ Hits 566 567 +1
Misses 63 63
Continue to review full report at Codecov.
|
| @@ -88,7 +88,7 @@ describe('dataReducer', () => { | |||
| `${collection}.${doc}.newData.field`, | |||
| data[doc].newData.field, | |||
| ); | |||
| expect(result).to.not.have.nested.property( | |||
There was a problem hiding this comment.
This test was in place for a reason - not removing a value which is removed from the object will cause stale data in certain situations
| @@ -59,11 +59,13 @@ export default function dataReducer(state = {}, action) { | |||
| state, | |||
| ); | |||
| } | |||
| // Otherwise merge with existing data | |||
| const mergedData = assign(previousData, data); | |||
There was a problem hiding this comment.
This will prevent removing a param from an object that is removed elsewhere - what is the goal here?
There was a problem hiding this comment.
The PR is meant to revert back an existing functionality that has been later removed (while kept in rrf - firebase), data merging.
When for a given collection you change the query to fetch new data (or next page for that matters) new data should be merged with existing data, at the moment is getting replaced.
What the PR is doing is just reverting back the files to their previous status (as mentioned in the issue open #294)
prescottprue
changed the title
Description
Check List
If not relevant to pull request, check off as complete
Relevant Issues
#294