Skip to content

Updated board2016#50

Merged
jackiekazil merged 8 commits intopresidential-innovation-foundation:masterfrom
Kazilico:UpdatedBoard2016
Mar 31, 2016
Merged

Updated board2016#50
jackiekazil merged 8 commits intopresidential-innovation-foundation:masterfrom
Kazilico:UpdatedBoard2016

Conversation

@Kazilico
Copy link
Copy Markdown
Contributor

I've changed the board members to the current members as well as changed from where their photos are sourced.

@jackiekazil
Copy link
Copy Markdown
Contributor

Will notify when this is ready.

@ajb
Copy link
Copy Markdown

ajb commented Mar 31, 2016

@jackiekazil: the tests are failing because Gemfile.lock is not checked-in to .git, and Travis is pulling a newer version of the html-proofer gem that has some incompatibilities.

If the tests pass locally, I would recommend checking-in your Gemfile.lock to version control (by removing it from .gitignore.)

@jackiekazil
Copy link
Copy Markdown
Contributor

@ajb and if it is not successfully passing locally?

@ajb
Copy link
Copy Markdown

ajb commented Mar 31, 2016

The failure is because of changes in the html-proofer module:
https://github.com/gjtorikian/html-proofer/releases/tag/v3.0.0

You can lock the version to '~>2.0' in your Gemfile, which might help... or
update the code that references it to reflect any changes that happened
between versions 2 and 3.

On Wed, Mar 30, 2016 at 10:53 PM, Jackie Kazil notifications@github.com
wrote:

@ajb https://github.com/ajb and if it is not successfully passing
locally?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#50 (comment)

Adam Becker
(951) 9-BECKER
@AdamJacobBecker

@ajb ajb mentioned this pull request Mar 31, 2016
@ajb
Copy link
Copy Markdown

ajb commented Mar 31, 2016

Hey Jackie, looks like you may have gotten this working.

I've also added #51, which I would recommend merging regardless.

@jackiekazil
Copy link
Copy Markdown
Contributor

@ajb for looking this over and helping!!!

@ajb
Copy link
Copy Markdown

ajb commented Mar 31, 2016

No prob!

On Wed, Mar 30, 2016 at 11:06 PM, Jackie Kazil notifications@github.com
wrote:

@ajb https://github.com/ajb for looking this over and helping!!!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#50 (comment)

Adam Becker
(951) 9-BECKER
@AdamJacobBecker

@greggersh
Copy link
Copy Markdown

I thought @ajb was a Laravel guy.

@jackiekazil jackiekazil merged commit 83ba185 into presidential-innovation-foundation:master Mar 31, 2016
@jackiekazil jackiekazil mentioned this pull request Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants