Skip to content

Conversation

ZacBlanco
Copy link

@ZacBlanco ZacBlanco commented Apr 7, 2025

This PR adds the discovery server from https://github.com/prestodb/discovery.

The change is split into a few commits

  1. Copies all the existing code for the discovery-server module file-for-file directly into the airlift repository
  2. Updates the airlift pom and discovery server pom with necessary changes to facilitate the build
    a. This intentionally changes the maven groupId from com.facebook.airlift.discovery to com.facebook.airlift to comply with the pattern that the rest of the modules in this project follow.
  3. Fixes checkstyle issues where the old project did not comply
  4. Changes from the modernizer plugin to comply and pass tests.

@ZacBlanco ZacBlanco force-pushed the add-discovery-server branch 3 times, most recently from c8db941 to 69eb6c5 Compare April 7, 2025 18:17
@ZacBlanco ZacBlanco marked this pull request as ready for review April 7, 2025 21:59
@ZacBlanco ZacBlanco requested a review from a team as a code owner April 7, 2025 21:59
@ZacBlanco ZacBlanco requested review from aaneja and jaystarshot April 7, 2025 21:59
Copy link

@aaneja aaneja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for making the modernizer fixes too!

@ZacBlanco ZacBlanco force-pushed the add-discovery-server branch 2 times, most recently from 755fda6 to e89456d Compare April 15, 2025 15:59
@ZacBlanco ZacBlanco force-pushed the add-discovery-server branch from e89456d to 684b2c3 Compare April 23, 2025 05:39
@ZacBlanco ZacBlanco force-pushed the add-discovery-server branch from 684b2c3 to fd9ce97 Compare April 23, 2025 05:43
@aaneja aaneja mentioned this pull request Apr 23, 2025
@ZacBlanco ZacBlanco closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants