Upgrade to Jetty 12 #103
Merged
Upgrade to Jetty 12 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the codebase to use jetty 12 along with all the dependent modules. There are a large number of changes outside of jetty that are required to comply with the updated APIs as well as some of the newer modernizer rules that execute with the target bytecode of some modules set to 17 The main types of changes are outlined below: 1. Nearly all usage of packages from javax.annotation, javax.validation javax.inject, javax.ws.rs-api, and javax.servlet have been replaced with the newer jakarta.* APIs. This is a requirement due to the newer jetty version requiring these libraries in order properly function. Some annotations have been removed entirely from the jakarta.annotation package, so they have been replaced with equivalent annotations from com.google.errorprone:error_prone_annotations package. Guice was upgraded to 7.0 to support the jakarta.inject namespace 2. Minimum bytecode level on some modules being raised to 17. Due to Jetty 12 being compiled for Java 17 bytecode, it means modules which rely on jetty directly and transitively must be compiled with java 17 bytecode as well. http-client and http-server are the modules with direct dependencies on jetty, but many other such as event, discovery, and more have their bytecode level increased in order to accomodate the jetty upgrade. Bytecode levels are set in the project's pom.xml <properties> tag using <project.build.targetJdk> 3. Modernizer changes. Due to modules being upgraded to Java 17 bytecode some new modernizer rules are now enforced to take advantage of the new Java 17 APIs. Many modules have slight changes to comply with our modernizer plugin. Most changes center around using Path instead of File and Java Streams API equivalents in place of Guava Iterables and Functions 4. The configuration's validator implementation is updated to use the hibernate validator instead of Apache bval-jsr. This is because the bval-jsr dependency does not support the jakarta namespace annotations at a java 8 bytecode level. Hibernate is used because it satisfies the requirement to keep this module at Java 8 bytecode. Aside from these, the rest of the changes center around supporting Jetty 12's new APIs within our http-client and http-server implementation. For example, supporting the new ContentProvider APIs and changing usages of deprecated or removed methods from Jetty 9.
|
Please retain attribution in your commit to the original author or at least add @wendigo with the |
|
@mosabua I've written all this code myself. Can you point to which changes you think need to be attributed? |
|
@ZacBlanco configuration changes are exactly the same as in the airlift/airlift for example |
|
That is not the case. One example at: is different than in airlift/airlift at the same location. I understand many changes will be similar due to mechanical renames from the javax to jakarta namespace, but there are plenty of places where I made changes that are very likely to be different from the upstream airlift repository. At no time while I authored this PR did I copy or cherry-pick any changes from airlift/airlift |
|
vs https://github.com/airlift/airlift/blob/28168d00c0ff551675974f70b3b363317660f69e/configuration-testing/src/main/java/io/airlift/configuration/testing/ConfigAssertions.java#L280 Even the exception message and extracted methods are the same (same structure, same naming, same variables) is so it's reasonable for me to have doubts. |
ZacBlanco
approved these changes
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone PR of #99
This PR moves airlift from Jetty 9.X to Jetty 12, the latest stable Jetty release. It provides a wide range of improvements
It also however requires significant refactoring of not just the Jetty libraries, but also moving things like javax servlets to the jakarta namespace as well as bumping the minimum bytecode version on components which rely on jetty to Java 17.