Skip to content

[drift] Use comma for fields of Enum #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[drift] Use comma for fields of Enum #108

merged 1 commit into from
Apr 29, 2025

Conversation

shangm2
Copy link

@shangm2 shangm2 commented Apr 29, 2025 •
edited
Loading

  1. we should use coma for fields within enum when generating idl files

@shangm2 shangm2 requested a review from a team as a code owner April 29, 2025 21:26
@shangm2 shangm2 requested a review from jaystarshot April 29, 2025 21:26
@ZacBlanco ZacBlanco changed the title Use coma for fields of Enum Use comma for fields of Enum Apr 29, 2025
@ZacBlanco ZacBlanco changed the title Use comma for fields of Enum [drift] Use comma for fields of Enum Apr 29, 2025
@NikhilCollooru NikhilCollooru merged commit df0f69f into prestodb:master Apr 29, 2025
2 checks passed
@shangm2 shangm2 mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZacBlanco ZacBlanco ZacBlanco approved these changes

@NikhilCollooru NikhilCollooru NikhilCollooru approved these changes

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner automatically assigned from prestodb/committers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shangm2 @ZacBlanco @NikhilCollooru