Skip to content

Conversation

shangm2
Copy link

@shangm2 shangm2 commented May 8, 2025

  1. For optional user-defined class, the metadata for it looks like
ThriftType{
protocolType=STRUCT,
javaType=java.util.Optional<com.facebook.drift.idl.generator.TreeNode>, 
valueTypeReference=Resolved reference to 
    ThriftType{
        protocolType=STRUCT, 
        javaType=class com.facebook.drift.idl.generator.TreeNode, 
        structMetadata=com.facebook.drift.idl.generator.TreeNode
    }
}

To print it out while generating idl file, we need to unwrap it.
2. This also include the change from #112 which will be cleared out after it gets merged.

@shangm2 shangm2 requested a review from a team as a code owner May 8, 2025 17:30
@shangm2 shangm2 requested a review from ZacBlanco May 8, 2025 17:30
@shangm2 shangm2 changed the title Optional custom class Support optional custom class while generating idl May 8, 2025
@shangm2 shangm2 changed the title Support optional custom class while generating idl Support optional use-defined class while generating idl May 8, 2025
@shangm2 shangm2 changed the title Support optional use-defined class while generating idl Support optional user-defined class while generating idl May 8, 2025
@shangm2 shangm2 changed the title Support optional user-defined class while generating idl [Drift] Support optional user-defined class while generating idl May 8, 2025
@shangm2 shangm2 force-pushed the optionalCustomClass branch 2 times, most recently from 82c630d to 74f5017 Compare May 19, 2025 04:34
@shangm2 shangm2 force-pushed the optionalCustomClass branch from 74f5017 to d039b6d Compare May 19, 2025 04:47
@NikhilCollooru NikhilCollooru merged commit 186a0af into prestodb:master May 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants