Skip to content

Conversation

unidevel
Copy link

@unidevel unidevel commented Jul 2, 2025

By the OSSRH Sunset Notice on https://central.sonatype.org/publish/publish-maven/

The legacy OSSRH publishing service will be sunset on June 30th, 2025. This documentation is for informational purposes and will be removed at that time. If you are currently publishing via this service, please migrate to the new Central Portal Publisher Service.

@unidevel unidevel requested a review from a team as a code owner July 2, 2025 21:04
Copy link
Member

@wanglinsong wanglinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unidevel unidevel force-pushed the migrate-ossrh branch 2 times, most recently from 27a5967 to e155300 Compare July 2, 2025 21:24
@unidevel
Copy link
Author

unidevel commented Jul 2, 2025

But I got compilation error when testing, full log => https://github.com/unix280/airlift/actions/runs/16036135999/job/45248251421#step:7:873

Error: ROR] COMPILATION ERROR : 
    [INFO] -------------------------------------------------------------
Error: ROR] /home/runner/work/airlift/airlift/configuration/src/main/java/com/facebook/airlift/configuration/ConfigurationFactory.java:[189,94] error: incompatible types: javax.inject.Provider<CAP#1> cannot be converted to jakarta.inject.Provider<?>
      where CAP#1,CAP#2 are fresh type-variables:
        CAP#1 extends CAP#2 from capture of ? extends CAP#2
        CAP#2 extends Object from capture of ?

@ZacBlanco
Copy link

This is likely because of the downgraded guice version which is introduced in the new airlift release. It will be fixed by #117 if we merge it first

@ZacBlanco
Copy link

I think we should get @rschlussel 's PR merged first and have her introduce the airbase 106 change, then this PR can just focus on fixing the release.

@unidevel
Copy link
Author

unidevel commented Jul 2, 2025

Merged #117 to my repo, and tested the release action => https://github.com/unix280/airlift/actions/runs/16036473767/job/45249324921

Seems fine, no deprecated ossrh publishing was found.

@unidevel unidevel requested a review from ZacBlanco July 8, 2025 05:12
@unidevel unidevel closed this Jul 8, 2025
@unidevel unidevel reopened this Jul 8, 2025
@unidevel
Copy link
Author

unidevel commented Jul 8, 2025

Seems I can not merge it by myself, @tdcmeehan @ZacBlanco @wanglinsong can you help to merge the PR? Thanks.

@ZacBlanco ZacBlanco merged commit c5baeec into prestodb:master Jul 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants