Fix QuantileDigestIterator bugs from #115 #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QuantileDigestIterator claims to perform a post-order traversal, but it actually has been performing in-order traversal. This is troublesome for most Q-Digest algorithms, which depend on post-order traversal.
The
upperBoundQuantile()
andlowerBoundQuantile()
functions were also not correct and have been removed and replaced with a simplecumulativeProportion()
. (To obtain lower bound and upper bound quantiles correctly, you need to separately perform forward and reverse iteration.)These are breaking changes, but the functions have no known usage.
See #115 for details and example.