Bring over changes from prestodb/drift #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give the commit a proper title about what feature it's adding? |
imjalpreet
reviewed
Aug 7, 2025
| import com.facebook.drift.protocol.TProtocolWriter; | ||
| import jakarta.inject.Inject; | ||
|
|
||
| import javax.inject.Inject; |
There was a problem hiding this comment.
nit: we can revert this. As part of the jetty upgrade, we migrated from javax.* to jakarta.*
There was a problem hiding this comment.
Since we downgraded guice, we actually still use javax.inject. You should see there are still usages of it throughout the codebase
There was a problem hiding this comment.
Oh, yes, forgot about that. So, we could use javax.inject as well, but I think in this case we should use jakarta.inject since this module is already using it in other classes.
rschlussel
reviewed
Aug 7, 2025
drift/drift-codec-utils/pom.xml
Outdated
| <optional>true</optional> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
and revert this too when you remove the javax import.
imjalpreet
reviewed
Aug 8, 2025
rschlussel
approved these changes
Aug 8, 2025
imjalpreet
approved these changes
Aug 8, 2025
|
@rschlussel can you please help merge this? |
ZacBlanco
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring over changes from 1c51d99a0a629f0cd42804b5e31e1da95c3575d6 and 6c688e781fe13faac1ffefecf03b7d2b9fb4e479