bug(listener): Add null check for content before updating response size #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds a null check for the ByteBuffer content in HttpServerChannelListener.onResponseWrite to prevent NullPointerExceptions when content is null, ensuring response size metrics are only updated when content exists. Sequence diagram for updated response size update in onResponseWritesequenceDiagram
participant Listener as HttpServerChannelListener
participant Req as Request
participant Size as AtomicLong
participant Content as ByteBuffer
Listener->>Req: getAttribute(RESPONSE_CONTENT_SIZES_ATTRIBUTE)
alt RESPONSE_CONTENT_SIZES_ATTRIBUTE is null
Listener->>Req: setAttribute(RESPONSE_CONTENT_SIZES_ATTRIBUTE, new AtomicLong(0L))
end
alt content != null
Listener->>Req: getAttribute(RESPONSE_CONTENT_SIZES_ATTRIBUTE)
Listener->>Size: addAndGet(content.remaining())
else content == null
Note over Listener: skips response size update
end
Class diagram for updated HttpServerChannelListener.onResponseWrite methodclassDiagram
class HttpServerChannelListener {
+onResponseWrite(Request request, boolean last, ByteBuffer content)
}
class Request {
+getAttribute(String key)
+setAttribute(String key, Object value)
}
class AtomicLong {
+addAndGet(long delta)
}
HttpServerChannelListener --> Request
Request --> AtomicLong
%% Highlight: onResponseWrite now checks if content != null before updating response size
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
aaneja
approved these changes
Oct 16, 2025
|
I have never seen this error anytime before. Wondering if this is a byproduct of upgrading to java 17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Presto can run into this error:
This PR will resolve it by adding a null check.