Repository navigation
Upgrade jetty to 12.1.11 (latest) - #150
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideJetty is upgraded to 12.1.11 and the custom async socket address resolver is updated to match the new Jetty API by adding a context parameter to the resolve method and delegating it correctly to the superclass. Sequence diagram for updated async socket address resolution with contextsequenceDiagram
actor ClientCode
participant JettyAsyncSocketAddressResolver
participant Promise
participant SuperResolver
ClientCode->>JettyAsyncSocketAddressResolver: resolve(host, port, context, promise)
JettyAsyncSocketAddressResolver->>JettyAsyncSocketAddressResolver: resolve(host)
alt address present
JettyAsyncSocketAddressResolver->>Promise: succeeded(ImmutableList.of(InetSocketAddress))
else address not present
JettyAsyncSocketAddressResolver->>SuperResolver: resolve(host, port, context, promise)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
imjalpreet
left a comment
There was a problem hiding this comment.
Thanks, @auden-woolfson.
Changes mostly LGTM. Can you please share a CI run in Presto by including the updated Airlift (via JitPack.io) before we merge these changes? This will eliminate any surprises later.
|
@imjalpreet here is the draft PR in presto to show CI run: I also ran unit tests on the
|
|
@auden-woolfson, thanks, I see the version being used for airlift in the presto PR is |
|
@auden-woolfson, also, I see there is a test suite failure for presto-pinot-toolkit (test-other-modules) in your Presto PR. Please look into it. |
This points here, I had to add some config file for jitpack so it's a separate branch master...auden-woolfson:airlift:upgrade_jettyio_jitpack Ok I will look into that failure, it is probably just flaky since UT pipeline passed |
|
@auden-woolfson, the pinot failure is a ClassNotFoundException, so I feel it might be related to the upgrade. But you can check from your end. |
|
I updated the branch to pull from my jitpack repo after another so the dependency that was failing in pinot toolkit resolves. There were 2 failures in the jenkins pipeline and I believe they are unrelated. Presto spark: Presto hive has some null pointer exceptions which should be unrelated and fixed in 1d989d1296483077248d61ddf13217a94e62f14f |
|
We had issues last time we were upgrading to 12.1.x - I'm all for moving to 12.1.x, but if we cannot figure out a fix for it soon, can we instead move to 12.0.38, which fixes CVE-2026-10051 that we wanted to address ? |
b2b6ed4 to
ed6850d
Compare
|
Rebased onto current @aaneja, on the 12.1.x history you linked, I went back through both failures and neither reproduces on 12.1.11:
Local verification on JDK 17 with
Identical. The 9
Presto side: prestodb/presto#28277 consumes a JitPack build of this branch. 93 of 95 checks pass. The two that do not are That run predates this rebase but still applies to it: everything between the old PR base and current master is release-plugin @imjalpreet, on the pinot Two things I would like to settle:
|
|
imjalpreet
left a comment
There was a problem hiding this comment.
Thanks, @auden-woolfson.
LGTM. One of the test suite([product tests (basic) / product-tests-basic-environment(17)) was failing in your Presto PR, so I have re-triggered it to confirm whether it was a flaky test. Once it passes, I will merge this.
## Description Upgrade Jetty from 12.0.38 to 12.1.11. Bump airlift from 0.231 to 0.232, which is built against Jetty 12.1.11 and adapts `JettyAsyncSocketAddressResolver` to the Jetty 12.1 `resolve` API. Airlift PR - prestodb/airlift#150 ## Motivation and Context Moves Presto to the latest Jetty release line (12.1.x). Airlift 0.231 is compiled against Jetty 12.0 and is not compatible with Jetty 12.1, so both versions are bumped together.




No description provided.