Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ jobs:
distribution: 'temurin'
cache: maven
- name: Maven install
run: mvn install
run: ./mvnw install
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@ jobs:
- name: Get release version
id: get-version
run: |
RELEASE_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout | tail -n 1 | sed 's/-SNAPSHOT//')
RELEASE_VERSION=$(./mvnw help:evaluate -Dexpression=project.version -q -DforceStdout | tail -n 1 | sed 's/-SNAPSHOT//')
echo "RELEASE_VERSION=$RELEASE_VERSION" >> $GITHUB_ENV
echo "RELEASE_VERSION=$RELEASE_VERSION"
echo "In case cut release failed, please delete the tag ${RELEASE_VERSION} manually"

- name: Prepare release
run: |
git reset --hard
mvn release:prepare -B -DreleaseVersion=${{ env.RELEASE_VERSION }} -DskipTests \
./mvnw release:prepare -B -DreleaseVersion=${{ env.RELEASE_VERSION }} -DskipTests \
-DautoVersionSubmodules=true \
-DgenerateBackupPoms=false
grep -m 1 "<version>" pom.xml
Expand All @@ -86,7 +86,7 @@ jobs:
git checkout ${{ env.RELEASE_VERSION }}
git ls -5
cat ~/.m2/settings.xml
mvn -V -B -U -e -T2C deploy \
./mvnw -V -B -U -e -T2C deploy \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Legacy builds bypass the pin

When the Jenkins release pipeline or Travis build is used, jenkins’ release steps and the Travis build still invoke system mvn, so those paths do not use the wrapper’s Maven 3.9.16; Jenkins explicitly runs Maven 3.8.6, and Travis remains dependent on its runner’s Maven version.

Switch those remaining Maven invocations to ./mvnw, or explicitly remove/decommission the legacy paths if they are no longer supported.

Also at .github/workflows/maven.yml:33.

Prompt for AI agents
In `.github/workflows/release.yml` at line 89:

**Legacy builds bypass the pin**

When the Jenkins release pipeline or Travis build is used, jenkins’ release steps and the Travis build still invoke system `mvn`, so those paths do not use the wrapper’s Maven 3.9.16; Jenkins explicitly runs Maven 3.8.6, and Travis remains dependent on its runner’s Maven version.

Switch those remaining Maven invocations to `./mvnw`, or explicitly remove/decommission the legacy paths if they are no longer supported.

Also at `.github/workflows/maven.yml:33`.

-DautoReleaseAfterClose=true \
-DkeepStagingRepositoryOnCloseRuleFailure=true \
-DkeepStagingRepositoryOnFailure=true \
Expand Down
4 changes: 4 additions & 0 deletions .mvn/wrapper/maven-wrapper.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
wrapperVersion=3.3.4
distributionType=only-script
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.16/apache-maven-3.9.16-bin.zip
distributionSha256Sum=5af3b743dd8b876b5c45da33b676251e5f1687712644abb4ee519ca56e1d89ce
295 changes: 295 additions & 0 deletions mvnw

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading