Skip to content

Add Router as a valid section header #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Router as a valid section header #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...lease-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ public class GenerateReleaseNotesTask
public static final List<Pattern> VALID_SECTION_HEADERS = ImmutableList.of(
"^General.*",
"^Prestissimo \\(Native Execution\\)",
"^Router",
"^Security",
"^JDBC Driver",
"^Web UI",
Expand Down
22 changes: 11 additions & 11 deletions ...ease-tools/src/test/java/com/facebook/presto/release/tasks/TestCheckReleaseNotesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public Object[][] sectionHeaders()
{"General"},
{"Prestissimo (Native Execution)"},
{"Security"},
{"Router"},
{"JDBC Driver"},
{"Web UI"},
{"Sample Connector"},
Expand All @@ -102,23 +103,22 @@ public Object[][] releaseNotesFailures()
// no edit to template
{Resources.toString(Resources.getResource("note_template.md"), StandardCharsets.UTF_8)},
// ambiguous, double release note blocks
{"== RELEASE NOTES ==\n changes\n* asdasd\n\n\n== NO RELEASE NOTES =="},
{"== RELEASE NOTES ==\n changes\n* Fix a thing\n\n\n== NO RELEASE NOTES =="},
// release note vs notes
{"== RELEASE NOTES ==\ngeneral\n* asd\n\n== RELEASE NOTE ==\ngeneral\n* asd"},
{"== RELEASE NOTES ==\ngeneral\n* asd\n\n== RELEASE NOTES ==\ngeneral\n* asd"},
{"== RELEASE NOTES ==\ngeneral\n* Fix a thing\n\n== RELEASE NOTE ==\ngeneral\n* Fix a thing"},
{"== RELEASE NOTES ==\ngeneral\n* Fix a thing\n\n== RELEASE NOTES ==\ngeneral\n* Fix a thing"},
// invalid section titles
{"== RELEASE NOTES ==\n\ngenerel chang\ntest"},
{"== RELEASE NOTES ==\n\ngeneral changes\ntest"},
{"== RELEASE NOTES ==\n\ncustom section\n* test"},
{"== RELEASE NOTES ==\n\ngenerel chang\n* Fix a thing"},
{"== RELEASE NOTES ==\n\ncustom changes\n* Fix a thing"},
// invalid note starts
{"== RELEASE NOTES ==\n\nGeneral Changes\n* test a thing"},
{"== RELEASE NOTES ==\n\nGeneral Changes\ntest a thing"},
{"== RELEASE NOTES ==\n\nGeneral Changes\n* Add test a thing\n* enhance a thing"},
{"== RELEASE NOTES ==\n\nGeneral Changes\nFix a thing"},
{"== RELEASE NOTES ==\n\nGeneral Changes\n* Fix a thing\n* enhance a thing"},
// multiple sections, one invalid section title
{"== RELEASE NOTES ==\n\nGeneral Changes\n* Add test a thing\n\nSNI changes\n* Add an SPI thing"},
{"== RELEASE NOTES ==\n\nGeneral Changes\n* Fix a thing\n\nSNI changes\n* Add an SPI thing"},
// multiple sections one invalid release note verb
{"== RELEASE NOTES ==\n\nGeneral Changes\n* Add test a thing\n\nSPI changes\n* bump version of an SPI thing"},
{"== RELEASE NOTES ==\n\nPrestissimo Native Execution Changes\n* Add test a thing\n\nSPI changes\n* bump version of an SPI thing"},
{"== RELEASE NOTES ==\n\nGeneral Changes\n* Fix a thing\n\nSPI changes\n* bump version of an SPI thing"},
{"== RELEASE NOTES ==\n\nPrestissimo Native Execution Changes\n* Fix a thing\n\nSPI changes\n* bump version of an SPI thing"},
};
}

Expand Down