Optimize row constructor code #15732
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikalur
force-pushed
the
optimize_row_constructor
branch
2 times, most recently
from
6b53e1a to
bb65dec
Compare
kaikalur
changed the title
kaikalur
force-pushed
the
optimize_row_constructor
branch
from
bb65dec to
39a90f1
Compare
rongrong
reviewed
Feb 22, 2021
| block.append(context.wasNull().set(constantFalse())); | ||
| Variable index = scope.createTempVariable(int.class); | ||
| BytecodeBlock loopBody = new BytecodeBlock(); | ||
| BytecodeNode forLoop = new ForLoop() |
There was a problem hiding this comment.
Can we add comment to each block with the corresponding java code so it would be easier to read / review? Thanks!
| query.append("ROW(obj.name, obj.value, obj.version, obj.matched_content_count, " + (i % 2 == 0 ? "1" : "false") + "),"); | ||
| } | ||
| query.append("null, 1) AS x,"); | ||
| //query.append("ROW(" + query + "1), "); |
| @@ -5662,4 +5662,19 @@ public void testMapUnionSumOverflow() | |||
| "select y, map_union_sum(x) from (select 1 y, map(array['x', 'z', 'y'], cast(array[null,30, 32760] as array<smallint>)) x " + | |||
| "union all select 1 y, map(array['x', 'y'], cast(array[1,100] as array<smallint>))x) group by y", ".*Value 32860 exceeds MAX_SHORT.*"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSingleItemCSE() | |||
There was a problem hiding this comment.
You probably want to just name this as testLargeRow?
kaikalur
force-pushed
the
optimize_row_constructor
branch
4 times, most recently
from
07d441f to
223f00f
Compare
kaikalur
force-pushed
the
optimize_row_constructor
branch
from
223f00f to
4842650
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
|
@rongrong Friendly ping. Please review this PR. Thank you! |
wanglinsong
requested review from
jaystarshot,
feilong-liu and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan - Added a test in AbstractTestQueries
We now generate a single variable for each distinct primitive type and one Object type variable for all non-primitives. This helps in reducing the bytecode size dramatically. We can now process the 1250 field row that's in the test just added - that was failing before this optimization.
We also generate a single field add code per field type and a single null handling block. This is the minimal code that we can generate in our current framework.