Skip to content

Map MySQL JSON to Presto JSON #16647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Map MySQL JSON to Presto JSON #16647

wants to merge 2 commits into from

Conversation

v-jizhang
Copy link
Contributor

Cherry-pick of trinodb/trino#45
solves #12806

Co-authored-by: Piotr Findeisen [email protected]

== RELEASE NOTES ==

General Changes
* Map MySQL JSON to Presto JSON
  :issue:`12806`

@v-jizhang v-jizhang force-pushed the mysql_json_2_presto_json branch from 00a456c to 0ba7c21 Compare August 25, 2021 17:00
@v-jizhang v-jizhang marked this pull request as draft August 25, 2021 18:34
@v-jizhang v-jizhang requested a review from aweisberg August 26, 2021 18:01
@v-jizhang v-jizhang marked this pull request as ready for review August 26, 2021 18:01
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 28, 2022
@v-jizhang v-jizhang reopened this Jul 20, 2022
@stale stale bot removed the stale label Jul 20, 2022
@v-jizhang v-jizhang mentioned this pull request Jul 20, 2022
Open
@v-jizhang v-jizhang force-pushed the mysql_json_2_presto_json branch from 0a9ab9c to d8dd7ba Compare July 21, 2022 00:25
@v-jizhang v-jizhang requested a review from a team as a code owner July 21, 2022 00:25
@v-jizhang v-jizhang requested a review from NikhilCollooru July 21, 2022 00:25
@v-jizhang v-jizhang marked this pull request as draft July 21, 2022 05:37
@v-jizhang v-jizhang force-pushed the mysql_json_2_presto_json branch from e06b136 to 269f830 Compare July 21, 2022 16:25
@v-jizhang v-jizhang marked this pull request as ready for review July 21, 2022 16:27
@v-jizhang v-jizhang requested review from a team, vinothchandar and 7c00 as code owners September 12, 2022 22:31
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 12, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@v-jizhang v-jizhang force-pushed the mysql_json_2_presto_json branch from a913e5a to bf4e6b1 Compare September 12, 2022 22:34
@prestoprobot
Copy link

@NikhilCollooru Friendly ping. Please review this PR. Thank you!

v-jizhang and others added 2 commits August 15, 2023 10:29
@v-jizhang @kokosing
Make type name to be Optional in JdbcTypeHandle
637b091 
Cherry-pick of trinodb/trino#523

Co-authored-by: Grzegorz Kokosiński <[email protected]>
@v-jizhang @ebyhr
Map MySQL JSON to Presto JSON
485efe7 
Cherry-pick of trinodb/trino#824

Co-authored-by: Yuya Ebihara <[email protected]>
@v-jizhang v-jizhang force-pushed the mysql_json_2_presto_json branch from bf4e6b1 to 485efe7 Compare August 15, 2023 17:51
@v-jizhang v-jizhang requested review from ericyuliu and removed request for aweisberg August 15, 2023 18:02
tdcmeehan
tdcmeehan approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiersten-stokes kiersten-stokes mentioned this pull request Aug 29, 2023
Open
@kiersten-stokes kiersten-stokes linked an issue Aug 29, 2023 that may be closed by this pull request
why presto query mysql data,the field will be transformed into char(0) #20681
Open
@tdcmeehan
Copy link
Contributor

@v-jizhang the test failure looks related, could you have a quick look?

@tdcmeehan tdcmeehan self-assigned this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@NikhilCollooru NikhilCollooru Awaiting requested review from NikhilCollooru NikhilCollooru is a code owner automatically assigned from prestodb/committers

@vinothchandar vinothchandar Awaiting requested review from vinothchandar

@7c00 7c00 Awaiting requested review from 7c00

@ericyuliu ericyuliu Awaiting requested review from ericyuliu

Assignees

@tdcmeehan tdcmeehan

Labels
awaiting-community-help backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

why presto query mysql data,the field will be transformed into char(0)
5 participants
@v-jizhang @prestoprobot @tdcmeehan @ethanyzhang @rohanpednekar