-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Improve ColumnarRow #16962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve ColumnarRow #16962
Conversation
14fa362
to
bb1b4c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesgpearce Looks good to me. Have you observed some measurable performance wins? Do you know if the changes are fully covered by existing tests?
This is pending collection from our testing environment. I suspect it's a modest improvement, mostly from its usage in
Yeah, the existing |
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
Extracted partially from trinodb/trino#9916
ColumnarRow#mayHaveNull()
and uses it inside of hive'sStructCoercer
ColumnarRow
instances fromDictionaryBlocks
that have no nulls