Fix bug when using ROUND(0.x, 0) #17003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
Cherry-pick of trinodb/trino#9371 From the original PR: "Before this commit, ROUND act like: presto> select round(0.7, 0); _col0 ------- 0.0 presto> select round(0.7); _col0 ------- 1 presto> select round(1.7, 0); _col0 ------- 2.0 round(0.7, 0) got wrong result 0.0, should be 1.0. After this commit, round(0.7, 0) returns 1.0" Co-authored-by: tinkerrrr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#9371
From the original PR:
"Before this commit, ROUND act like:
round(0.7, 0) got wrong result 0.0, should be 1.0. After this commit, round(0.7, 0) returns 1.0"
Co-authored-by: tinkerrrr [email protected]