Validate the end of input when parsing JSON #17377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of trinodb/trino#10783 Before this change, the end of input after reading a JSON value was not properly validated: - if there were remaining characters which did not parse as JSON, exception was thrown. E.g. `'["correct JSON"]and more'` failed - if there were remaining characters which formed a valid token, they were silently ignored. E.g. `'["correct JSON"]{and more'` succeeded and returned `'["correct JSON"]'` After this change, any trailing characters are caught and reported as error. Co-authored-by: kasiafi <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
wanglinsong
requested review from
jaystarshot,
feilong-liu and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#10783
Before this change, the end of input after reading a JSON value
was not properly validated:
exception was thrown. E.g.
'["correct JSON"]and more'failedthey were silently ignored. E.g.
'["correct JSON"]{and more'succeeded and returned
'["correct JSON"]'After this change, any trailing characters are caught and reported
as error.
Co-authored-by: kasiafi [email protected]
Test plan - Added tests