[DRAFT] Removing scheduler hard coded request timeout value #17396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When coordinator gets full GC pause which lasts more than 10 second, all scheduler requests to workers times out. This result in retrying those requests. With 100s of tasks requests retry, causing memory pressure on coordinator if it's running on low memory machine. Removing this config to make it configurable so we can tune it per cluster.
swapsmagic
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When coordinator gets full GC pause which lasts more than 10 second, all scheduler requests to workers times out.
This result in retrying those requests. With 100s of tasks requests retry, causing memory pressure on coordinator if it's
running on low memory machine. Removing this config to make it configurable so we can tune it per cluster.
Test plan - unit tests and verifier run